Merged
Conversation
fvictorio
approved these changes
Jan 30, 2026
Member
There was a problem hiding this comment.
I think I like this option more. I only left a small comment.
I didn't review every single line here, but my understanding is that the three groups of changes are:
- We pass the
collectedMetadatain every constructor (that's what affects almost every changed line in this PR). - That is used instead of the global collections that were used before (only relevant in
src/types.d.ts,slangSolidityParser.ts, andSlangNode.ts) - Some imports now use the
.d.tsextension instead of.ts
Assuming that understanding is correct, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #1392 but instead of piggybacking on the Prettier's
options, we add our own collected metadata object.